Change #1072211 merged by jenkins-bot:

[mediawiki/core@master] Allow localized gallery widths; avoid spurious "double px" tracking category

https://gerrit.wikimedia.org/r/1072211

No longer reproducible

Currently this is confusing some editors who think that because there is a tracking category added to <gallery> images because of this bug, they need to remove px from the galleries. What is holding back the patch from getting reviewed?

In T257652#10185741, @Forza1000 wrote:

In T257652#9997534, @Jonathanischoice wrote:

I am now down a rabbit hole updating someone's BRISQUE, PIQE and NIQE code. It mostly now seems to work, but I don't have an NVidia card to test the BRISQUE code on.

Hi. Do we have any updates regarding this ticket? 🙏

In T257652#9997534, @Jonathanischoice wrote:

I am now down a rabbit hole updating someone's BRISQUE, PIQE and NIQE code. It mostly now seems to work, but I don't have an NVidia card to test the BRISQUE code on.

Nobody is going to track down what happened a month ago - it's well known and tracked elsewhere that file management unearths gremlins.

Same issue in a desktop browser with MediaViewer on
https://fr.m.wikipedia.org/wiki/Guerre_du_Donbass#/media/Fichier%3AMinsk_Protocol.svg serving https://upload.wikimedia.org/wikipedia/commons/thumb/f/fb/Minsk_Protocol.svg/583px-Minsk_Protocol.svg.png
but not with the non-mobile URL on
https://fr.wikipedia.org/wiki/Guerre_du_Donbass#/media/Fichier%3AMinsk_Protocol.svg serving https://upload.wikimedia.org/wikipedia/commons/thumb/f/fb/Minsk_Protocol.svg/langfr-800px-Minsk_Protocol.svg.png

This bug still present in MediaWiki 1.42.1

If a file was uploaded correctly the API should always respond with:

{'upload': {'result': 'Success',...

Yess... until there's an error when sending the success response itself

Change #1072822 had a related patch set uploaded (by C. Scott Ananian; author: C. Scott Ananian):

[mediawiki/services/parsoid@master] WIP: parse gallery specs with localized 'px' suffixes

https://gerrit.wikimedia.org/r/1072822

Change #1072211 had a related patch set uploaded (by C. Scott Ananian; author: C. Scott Ananian):

[mediawiki/core@master] Allow localized gallery widths; avoid spurious "double px" tracking category

https://gerrit.wikimedia.org/r/1072211

The width *should* be parsed with the "magic word" img_width, which includes the trailing px (localized in many cases, for example in Esperanto it also allows a trailing re). As such, the value which arrives at Parser::parseWidthParam() should /not/ have a trailing px.
It appears that renderImageGallery is not parsing the widths attribute with img_width (which also means the attribute value is not being properly localized). I'll work on a patch.

@Pppery I'll take a look. It's not intended, but gallery *is* somehow triggering the code path where "px has already been parsed and we saw another one". Perhaps that's because gallery itself is adding a hidden px.

In T374311#10131678, @Pppery wrote:

@cscott Is this intended to populate the tracking category? I personally think it's reasonable behavior that both <gallery widths=180> (concise) and <gallery widths=180px> (technically redundant but clearer) are accepted and don't populate the category. Both syntaxes are widely used.

That is T374311

I just noticed that pages are categorized when using this syntax:

Why was this change deployed? I don't see a link to an affected article or page. These errors were already tracked via the Linter "bogus file options" flag, as far as I know. I fixed hundreds or thousands of them at en.WP.

This is clearly a bug.

@cscott Is this intended to populate the tracking category? I personally think it's reasonable behavior that both <gallery widths=180> (concise) and <gallery widths=180px> (technically redundant but clearer) are accepted and don't populate the category. Both syntaxes are widely used.

Seems fine to me.

Adding https://arxiv.org/abs/1910.06005 and https://wikiview.net to the list of related projects

Change #1037502 merged by jenkins-bot:

[mediawiki/core@master] StreamFile: Support streaming webp from thumb_handler.php

https://gerrit.wikimedia.org/r/1037502

It looks like this isn't available until the deployment train, so I'll hesitantly postpone the entry until the following week (so that folks can immediately look at the contents), unless you think it is urgent that editors be warned about it's arrival beforehand. Also, I see in the blue notice-box at https://www.mediawiki.org/wiki/Help:Tracking_categories that the category is likely to be empty/very incomplete at the start, because tracking categories aren't all instantly filled, and have to wait for each page to be re-parsed.
The text for Tech News could be something like:

Editors who help to cleanup broken wikitext can now use a new automatic [[Special:TrackingCategories|tracking category]] named "[[:Category:{{int:Double-px-category}}]]". Pages in this category contain images that specify multiple "px" values instead of just one. [ 1 ]

Suggested wording for Tech News:

Change #1064409 merged by jenkins-bot:

[mediawiki/core@master] Add `double-px-category` tracking category for deprecated image size syntax

https://gerrit.wikimedia.org/r/1064409