Page MenuHomePhabricator

MUL - Show `mul` as the last language in the "In more languages" section of desktop termbox by default
Closed, ResolvedPublic8 Estimated Story Points

Assigned To
Authored By
Manuel
Aug 31 2022, 12:22 PM
Referenced Files
F37101308: image.png
Jun 12 2023, 10:58 AM
F37101306: image.png
Jun 12 2023, 10:58 AM
F36913033: image.png
Mar 15 2023, 2:22 PM
F36913031: image.png
Mar 15 2023, 2:22 PM
F36845476: image.png
Feb 15 2023, 10:18 AM
F35500874: grafik.png
Aug 31 2022, 12:52 PM

Description

User story:
As a Wikidata editor,
I want to find the mul Labels and Aliases at a consistent place in the termbox,
so that I am always able to find it quickly.

Solution:

  • Always show mul as the last language in the "In more languages" section.
    • It is not relevant if the mul Label or Aliases are empty or not.
    • A consistent place is preferable to 'mul' jumping around from entity to entity. We chose the bottom position as it is unproblematic even for non-Latin UI users and entities that should not use mul. Also, it makes the fallback functionality intuitive.
  • All Wikibase products will in the future get mul as an option (tmpEnableMulLanguageCode).
    • Initially, we will not activate this particular feature in Wikidata either to allow for a soft rollout. So this needs to be configurable via a second (temporary) flag.

Mockup:

image.png (525×1 px, 88 KB)

Expected fallback:

image.png (230×652 px, 17 KB)

Notes:

  • T336781 solves the same issue for mobile termbox.

BDD:

If mul is NOT specified in the user's Babels:

After the soft rollout, show mul as the last language in the "In more languages" section.

GIVEN a wikibase where mul is enabled
AND the soft rollout phase has successfully ended (=configured for normal use/no soft rollout flag exists)
AND the user has not specified mul in their Babels (OR the Babel extension is disabled)
WHEN editing or viewing an Item on (mobile or) desktop

During the soft rollout, if mul is NOT already used in the entity, do NOT show mul.

GIVEN a wikibase where mul is enabled
AND we are only in the soft rollout phase (=configured for limited rollout)
AND the user has NOT specified mul in their Babels
AND mul is not already used in the entity
WHEN editing or viewing an Item on (mobile or) desktop
THEN do NOT show mul

If mul is already used in an entity, then show mul as the last language in the "In more languages" section. (This case is covered by the general case after the soft rollout.)

GIVEN a wikibase where mul is enabled
AND the user has NOT specified mul in their Babels
AND the Item uses mul
WHEN editing or viewing an Item on (mobile or) desktop
THEN show mul as the last language in the "In more languages" section of termbox

Exception in case mul is specified in the user's Babels:

During the soft rollout, if mul is specified in a user's Babels, show mul as the last language in the "In more languages" section.

GIVEN a wikibase where mul is enabled
AND the Babel extension is enabled
AND the user has specified mul in their Babels
WHEN editing or viewing an Item on (mobile or) desktop
THEN show mul as the last language in the "In more languages" section.

Open questions:

  • How can we best test the two configurations for soft rollout (enabled/disabled)?

Acceptance criteria:

  • There is a soft rollout flag configurable to change the behavior during soft rollout.

During soft rollout:

  • During the soft rollout, if mul is NOT already used in the entity, do NOT show mul.
    • Exception: If mul is specified in a user's Babels, then show mul as the last language in the "In more languages" section.
    • Exception: If mul is already used in an entity, then show mul as the last language in the "In more languages" section.

After soft rollout:

  • After the soft rollout, show mul as the last language in the "In more languages" section.

Release:

  • Release to test.wikidata.org

Related Objects

Event Timeline

There are a very large number of changes, so older changes are hidden. Show Older Changes
Manuel renamed this task from Change the order of Labels on Wikidata so that mul always comes first to Change the order of Labels in the termbox on Wikidata so that mul always comes first.Sep 6 2022, 2:37 PM
Manuel updated the task description. (Show Details)
Manuel updated the task description. (Show Details)
karapayneWMDE renamed this task from Change the order of Labels in the termbox on Wikidata so that mul always comes first to MUL - Change the order of Labels in the termbox on Wikidata so that mul always comes first.Sep 13 2022, 9:59 AM

@Manuel , from sprint 8 planning

  • does this include mobile termbox as well?
  • if having mul always on top is a simpler/easier implementation, do you agree with going with this implementation (over the request here of if it exists, then its on top)?

does this include mobile termbox as well?

Yes, "mobile termbox" was referred to as "new termbox" in the AC.

if having mul always on top is a simpler/easier implementation, do you agree with going with this implementation (over the request here of if it exists, then its on top)?

The "if it exists, then its on top" is unfortunately an essential intermediary part of the planned incremental release strategy (see T312097) for this:

v1.0: In the first release version, editors are not supposed to be able to create a new mul Label for an Item by default (but only if they have put mul to their babels). The reason for this is that the UX will be bad while there are no well established guidelines or helpful UI tweaks to support it.

v2.0: After the Community has created guidelines and we have linked to them in the UI we will open mul for all users by default. This is when we can change the behavior to "mul always on top".

Should this strategy add too much complexity from an engineering perspective, please let me know.

Manuel reopened this task as Open.
Manuel claimed this task.
Manuel removed a project: Wikidata Dev Team.
Manuel moved this task from Ready to estimate to Task with Epic on the Wikidata-Campsite board.
Manuel renamed this task from MUL - Change the order of Labels in the termbox on Wikidata so that mul always comes first to MUL - Show mul language code at a consistent place in the termbox on Wikidata .Nov 15 2022, 11:13 AM
Manuel updated the task description. (Show Details)
Manuel renamed this task from MUL - Show mul language code at a consistent place in the termbox on Wikidata to MUL - Always show `mul` as the last language in the "In more languages" section of termbox.Feb 14 2023, 5:40 PM
Manuel updated the task description. (Show Details)
Manuel updated the task description. (Show Details)
Manuel updated the task description. (Show Details)
Manuel renamed this task from MUL - Always show `mul` as the last language in the "In more languages" section of termbox to MUL - Always show `mul` as the last language in the "In more languages" section of termbox if configured.Feb 14 2023, 5:50 PM
Manuel renamed this task from MUL - Always show `mul` as the last language in the "In more languages" section of termbox if configured to MUL - Show `mul` as the last language in the "In more languages" section of termbox by default.Feb 14 2023, 6:41 PM
Manuel updated the task description. (Show Details)
Manuel updated the task description. (Show Details)
Manuel updated the task description. (Show Details)
Manuel renamed this task from MUL - Show `mul` as the last language in the "In more languages" section of termbox by default to MUL - Show `mul` as the last language in the "In more languages" section of desktop termbox by default.May 16 2023, 3:52 PM
Manuel updated the task description. (Show Details)

The description seems to assume that users are able to specify the order of languages in the Termbox via Babel.
I played around with this a bit, and that seems false.

With this Babel:

image.png (393×267 px, 34 KB)

I'm still getting this ordering:

image.png (484×318 px, 30 KB)

Note that German is in the last position, not somewhere at the top.

I just checked again and it works for me. Could you please verify that you logged in with the same account?

I just checked again and it works for me. Could you please verify that you logged in with the same account?

Those screenshots are from the same account. Could you elaborate what exactly you tried and what "works for you" means in detail?

Sprint Planning Notes:

  • @Manuel can investigate further regarding the babel ordering, to add a new feature to take this into account
  • The easiest requirement to initially address is that the mul languages will always be set to the bottom
  • Perhaps a technical investigation is also required to understand how this works
ItamarWMDE set the point value for this task to 8.Jun 13 2023, 9:31 AM

@Michael: You are right! It was just a coincidence that my tests worked. The Babel-defined rows are in alphabetical order (by language code, as Marius mentioned). I have clarified the task accordingly.

Thank you for bringing this up!

Task Breakdown Notes

  • the current status quo of who sees the MUL language code on test wikidata should remain
  • subtask 1 - show MUL as last language if any MUL terms exist (@Michael )
  • subtask 2 - create the feature flag to always show the MUL language code (@Lucas_Werkmeister_WMDE )

Open questions:

  • On which tests systems should the feature flag be enabled/disabled? E.g. enabled on Beta, disabled on Test Wikidata or vice versa @Manuel

E.g. enabled on Beta, disabled on Test Wikidata or vice versa @Manuel

Yes, that is a great idea! My suggestion would be to simulate the soft rollout phase on the system that is more similar to Wikidata (as this is what we will initially release) and always show the MUL language code on the other system (as we will still be able to test this at a later point in time).

I think this is ready for verification – we have the soft rollout state (mul shown as last language only if a term exists or babel contains mul) on Test Wikidata, and the eventual final state (mul always shown as last language) on Beta Wikidata.

Manuel claimed this task.

And verified! Thank you, it's working like a charm! \o/