Jump to content

Wikipedia talk:XFDcloser

Page contents not supported in other languages.
From Wikipedia, the free encyclopedia

Evad37 feature ideas[edit]

Moved from top of page to its own talk page section. I think Evad37 wrote these. –Novem Linguae (talk) 16:36, 15 June 2024 (UTC)[]

What are the highest priority software bugs and feature requests for XFDcloser? - Evad37 [talk] 14:30, 12 January 2022 (UTC)[]

The backlog of bugs and feature requests as noted in the other sections of this page has built up quite a lot, especially over the past year or so while I haven't been so active on Wikipedia. Finding out what the community's priorities are would help me, as the primary author/maintainer of XFDcloser, to decide the order in which I work on issues. Note that responses here will just be one factor, with the other main factor being the scope/complexity of coding changes required. - Evad37 [talk] 14:30, 12 January 2022 (UTC)[]

I relisted around 7 or 8 discussions and they were removed from the 8/10/23 AFD log page but not put on to the 8/17/23 page. So, I cut and pasted them manually. But relisting happens a lot so I hope whatever problem is happening can get fixed. Thanks. Liz Read! Talk! 03:22, 17 August 2023 (UTC)[]

So, XFDcloser did relist discussions but to the wrong date, to August 16th even though it became August 17th UTC hours ago. Anyone else seeing this problem? Liz Read! Talk! 04:48, 17 August 2023 (UTC)[]
@Liz, #CfD relisting date bug?. Yes, me. — Qwerfjkltalk 09:37, 17 August 2023 (UTC)[]
Hello, Qwerfjkl,
Thanks for pointing this out. I wonder how often the XFDcloser developers monitor this talk page. Liz Read! Talk! 06:06, 27 August 2023 (UTC)[]
I have been posting here since early last year, and I don't see any one monitoring this talk page. Jay 💬 06:31, 27 August 2023 (UTC)[]
@Jay, @Liz, see #Relisting failure at CFD above; the sole maintainer has been inactive for a year and a half. — Qwerfjkltalk 06:37, 27 August 2023 (UTC)[]
I've got this page watchlisted and may jump in and write patches at some point. Just need some free time. –Novem Linguae (talk) 20:31, 27 August 2023 (UTC)[]
This relisting problem is still an issue. I relisted several discussions last night where the AFD discussions weren't removed from the daily log page. But the bigger problem is when XFDcloser removes the discussion from the current daily log but doesn't repost it to the future daily log so the discussion completely disappears from our AFD pages. We used to have a few editors who looked for AFD discussions that fell through the cracks like this and were never closed and they would repost them, sometimes months later. I'd say we have XFDcloser relisting problems about 1-5% of the time so it's not often but it's regular enough that I wish a developer would look into it. Liz Read! Talk! 02:36, 11 January 2024 (UTC)[]
The next time this happens, if y'all can provide some diffs, that would help with debugging. I'll need to copy wikicode of several pages over to testwiki to try to recreate this, and diffs would provide this wikicode. –Novem Linguae (talk) 06:55, 7 June 2024 (UTC)[]
Above, someone mentioned that it was relisting to the wrong log page. Below, someone mentioned that it was not relisting to any log page, or did not remove the relist from the old log page. Hmm.
Someone mentions this happens on 1-5% of relists. 1-5% of the time could be a wikicode issue (easy to fix), the log page not created yet (easy to fix), a race condition (hard to fix), or connection issues such as jQuery error http (hard to fix). –Novem Linguae (talk) 07:00, 7 June 2024 (UTC)[]

 You are invited to join the discussion at Wikipedia:Village Pump (proposals) § Bump XfD heading sizes. Primefac (talk) 20:22, 29 January 2024 (UTC)[]

In this edit, the only link in a "See also" section was removed but the heading remained. Preferably, it would remove the heading in that case. ~Bobogoobo (talk) 05:37, 19 May 2024 (UTC)[]

Hi all

About a week ago, XFDcloser has vanished from when I view AfD's. I have checked across three different computers, all of which use Google Chrome (latest version).

Have tried deactivating and reactivating through preferences, also to no avail.

I am technologically deficient in many respects so I'm sure I'm missing something obvious - has anyone else encountered this issue, or alternatively does anyone know a fix I should try?

Cheers
Daniel (talk) 21:48, 27 May 2024 (UTC)[]

@Daniel. Any WP:CONSOLEERRORs on pages where you expect XFDCloser to display? –Novem Linguae (talk) 01:15, 28 May 2024 (UTC)[]
Hi User:Novem Linguae, three it seems (tested on page Wikipedia:Articles for deletion/EcoCute (Japan)):
Do I have any idea what any of these mean? You bet I don't! Any help obviously greatly appreciated. Daniel (talk) 01:55, 28 May 2024 (UTC)[]
Those are just notices and arent the smoking gun i was hoping for. Thank you for checking though. –Novem Linguae (talk) 03:03, 28 May 2024 (UTC)[]
OK, so...I changed from Monobook to Vector (2022) and the closing buttons have reappeared (with no other changes on my part). It's a shame, cos I love Monobook (call me old-fashioned), but it seems like something with the Monobook isn't agreeing with XFDCloser. They also work in Vector Legacy (2010) and that looks similar to Monobook, so that's a suitable workaround from my perspective. Daniel (talk) 03:17, 28 May 2024 (UTC)[]
Daniel, there were recent changes to the header HTML for certain skins, which is probably what caused this. These changes will also be rolled out for both vectors at some point in the future. — Qwerfjkltalk 05:53, 28 May 2024 (UTC)[]
Hi Qwerfjkl, thanks for the update. Confirming both Vectors are working as of right now...with any luck Monobook will work nicely with XFDCloser some time in the future, although it's not a massive issue to use Vector (2010). Daniel (talk) 06:42, 28 May 2024 (UTC)[]
I'm able to reproduce on Monobook. This should be pretty easy to patch. The hard part will be figuring out how to test and deploy it. Looks like this tool hasn't had a patch in two years so it's unlikely the maintainer is around. I might look into this tomorrow. –Novem Linguae (talk) 10:02, 28 May 2024 (UTC)[]
OK, I figured it out and wrote a patch. I'll give @Evad37 a couple days to see the GitHub emails and see if they want to comment. If Evad is MIA, I have enough access to deploy this (intadmin, wikimedia-gadgets member), but would rather check with them first :) –Novem Linguae (talk) 15:17, 29 May 2024 (UTC)[]
I probably should have mentioned this earlier, but it's due to mw:Heading HTML changes; see also the phab ticket linked there. — Qwerfjkltalk 06:38, 30 May 2024 (UTC)[]
Came here to ask about this, and see there's already a fix in the pipeline. Much appreciated, Novem Linguae. Seraphimblade Talk to me 19:06, 1 June 2024 (UTC)[]
I just did a deployment. Should be  Fixed.
Please ping me if the deployment breaks anything. It's my first time deploying for this repo. The minified file has an unexplained -50,000 bytes. However my quick checks didn't find anything broken. –Novem Linguae (talk) 11:57, 2 June 2024 (UTC)[]

Howdy folks. I might be interested in doing some work on this gadget. And there's like 100 sections on this page. Can you please give me a recap of what you think the most serious bugs are? So I can start to prioritize. Feel free to link to the appropriate sections above too. Thank you. P.S. Let's focus on bugs rather than feature requests for now. –Novem Linguae (talk) 02:32, 2 June 2024 (UTC)[]

Novem Linguae, at CfD, the only major bug I've experienced is that XfDCloser can't handle nominations with >50 pages; it'll have something like "http error". This is probably due to the limit of 50 pages per API request for non-admin or bot accounts (the higher limits are 500), and XfDCloser doesn't batch requests properly. Sometimes this error causes XfDCloser to fail on the rest of the page, though this is pretty rare. — Qwerfjkltalk 11:32, 2 June 2024 (UTC)[]
Biggest bugs seem to be around RFD and CFD. This thread from 2022 also has some of the "best of" issues that people are experiencing. I also noticed (going through all of the threads on this page) that many of these are likely one-time issues (and a few of them actually were resolved and just not archived). I'll try to do a second pass... soonish... and tag the ones that I think were sorted out Primefac (talk) 10:45, 7 June 2024 (UTC)[]
Yes, Fayenatic london's comments there are pretty much all still applicable to CfD. — Qwerfjkltalk 14:32, 7 June 2024 (UTC)[]
@Fayenatic london's comments in #RFC: Priorities for XFDcloser development in 2022 were great. I turned each comment into a ticket just now. I also ticketized the other comments in that section. Ticketizing the big issues is a good first step to getting a volunteer developer to work on this stuff. –Novem Linguae (talk) 10:23, 11 June 2024 (UTC)[]
Novem Linguae, I've submitted a pull request that (should) fix this, would appreciate if you could take a look at it. — Qwerfjkltalk 20:56, 25 June 2024 (UTC)[]

Missing links about half the time[edit]

Novem Linguae, I probably should have mentioned this before, but:
The main bug I have is XFDCloser not loading. It fails haphazardly, so I assume the issue is a race condition with other scripts. For reference, heres what my HTML looks like with the other scripts loaded (not XFDCloser):
<h4 data-mw-thread-id="h-Category:Legendary_creatures-June_12-20240602121000" style="overflow: visible;" title="Latest: 9 days ago | 10 comments | 8 contributors" class="xfd-closed">
  <span class="mw-headline" id="Category:Legendary_creatures">
    <span data-mw-comment-start="" id="h-Category:Legendary_creatures-June_12-20240602121000"></span>Category:Legendary creatures <span data-mw-comment-end="h-Category:Legendary_creatures-June_12-20240602121000"></span>
  </span>
  <a class="copy-section-link-pilcrow" display="inline"></a>
  <span class="mw-editsection">
    <span class="mw-editsection-bracket">[</span>
    <a href="/w/index.php?title=Wikipedia:Categories_for_discussion/Log/2024_June_12&amp;action=edit&amp;section=6" title="Edit section: Category:Legendary creatures" class="nonimage sectionEditLink">
      <span>edit</span>
    </a> | <a class="copysectlink mw-selflink-fragment nonimage" href="/wiki/Wikipedia:Categories_for_discussion/Log/2024_June_12#Category:Legendary_creatures" role="button" title="#Category:Legendary creatures">copy</a> | <a>List discussion</a> | <span class="dropdown-container" style="position:relative; display:inline-block; ">
      <a class="dropdown-trigger" style="color: #0645AD; text-decoration: none; cursor: pointer">One click close</a>
      <span class="dropdown-menu" style="display: none; position: absolute; background-color: #fff; border: 1px solid #ddd; box-shadow: 0 2px 5px rgba(0, 0, 0, 0.1); padding: 5px; min-width: 6em; z-index: 1; left: 0px; top: 0.8em;">
        <a style="display: block; color: #0645AD; text-decoration: none; padding: 10px; margin-top: 5px; font-size: 150%" class="dropdown-item">delete</a>
        <a style="display: block; color: #0645AD; text-decoration: none; padding: 10px; margin-top: 5px; font-size: 150%" class="dropdown-item">rename</a>
        <a style="display: block; color: #0645AD; text-decoration: none; padding: 10px; margin-top: 5px; font-size: 150%" class="dropdown-item">merge</a>
      </span>
    </span>
    <span class="mw-editsection-bracket">]</span>
    <span id="FTTLink-heading-82" class="FTTLinks FTTHeadingLinks">
      <a title="Permanent link" href="#Category%3ALegendary_creatures" id="genLink-82" class="FTTGenLink" tabindex="0">
        <span class="FTTReplyLink FTTSVG FTTSVGLinkIcon">
          <span class="FTTScreenReaderLabel" data-content="Permanent link"></span>
        </span>
      </a>
      <a tabindex="0" class="FTTCmtA" onclick="event.preventDefault();event.stopPropagation();FTT.openReplyForm(FTT.PRM[82])">
        <span title="Add new comment or subsection" class="FTTReplyLink FTTSVGNewSectionIcon FTTSVG">
          <span class="FTTScreenReaderLabel" data-content="Add new comment or subsection"></span>
        </span>
      </a>
      <a tabindex="0" class="FTTSecEdit">
        <span title="Edit section" class="FTTReplyLink FTTSVGEditIcon FTTSVG">
          <span class="FTTScreenReaderLabel" data-content="Edit section"></span>
        </span>
      </a>
      <span>
        <a tabindex="0" title="Subscribe" class="FTTSubscribe FTTSVG FTTReplyLink FTTSVGBellIcon" onclick="FTT.stalkSubscribe(FTT.PRM[82],'bellicon',null,event);">
          <span class="FTTScreenReaderLabel" data-content="Subscribe"></span>
        </a>
      </span>
    </span>
  </span>
</h4>
It would be nice if XFDCloser was more robust at handling this kind of stuff. (And yes, I realise there's an open phab ticket for an API to add links to section headers). — Qwerfjkltalk 17:57, 21 June 2024 (UTC)[]
Sounds like the page is Wikipedia:Categories for discussion/Log/2024 June 21#Category:Legendary creatures. What skin are you using? What percent of the time does it fail? Does it fail often enough that you could disable half your user scripts, then another half, etc. to narrow it down to one user script that it's conflicting with? When it fails, are there any WP:CONSOLEERRORs? –Novem Linguae (talk) 02:39, 22 June 2024 (UTC)[]
Novem Linguae, Vector 2022; about half perhaps, hard to pin down; the scripts are probably WP:FACTOTUM, User:Enterprisey/copy-section-link (or something similar; I seem to have that disabled), User:Nardog/CopySectLink, and User:Qwerfjkl/scripts/CFDlister. There are no console errors. I will see if I can get a screen recording. — Qwerfjkltalk 15:22, 22 June 2024 (UTC)[]
I was able to reproduce using your common.js settings. I agree that it's probably a race condition. If another user script changes the HTML in that area, it could mess up XFDcloser's attempt to add its links. Might try disabling WikiNotes as a test and see if that fixes it, because that user script is putting links in the same area as XFDcloser. If that doesn't work, because I'm able to reproduce it, we know that it's something in your common.js, so you could use a bisect technique to figure out what script is conflicting. Bisecting involves commenting out half of your common.js, then seeing if that fixes it. If it does, then comment out half of that. If it doesn't, then re-enable that half and comment out the other half. And so on and so forth. You'd have to refresh a bunch of times to be sure since this is only happening like 50% of the time. –Novem Linguae (talk) 14:18, 23 June 2024 (UTC)[]
As typical, the issue has disappeared for now. I'll report back when it reappears. — Qwerfjkltalk 15:12, 23 June 2024 (UTC)[]

Are XFDcloser links supposed to show for RFD/TFD/etc entries that are hatted? Currently the links are showing in some cases. I am wondering if this is a bug, or useful behavior. –Novem Linguae (talk) 02:36, 2 June 2024 (UTC)[]

I figured it out. They are not supposed to show for hatted sections, relisted sections on the old page, etc. The XFDcloser links are supposed to be hidden if the XFD is already actioned. –Novem Linguae (talk) 04:27, 2 June 2024 (UTC)[]
Resolved

For some reason, the regular XFDcloser options are not showing up on AFD discussions. I've uninstalled all of the programs and unselected the gadget. Then I selected the gadget again in the Preferences again but still, no options appear that would allow me to close a discussion. What's up here? Liz Read! Talk! 23:21, 6 June 2024 (UTC)[]

This is likely a WP:THURSDAY issue. They done broke something big in this one because it's not the only one I've seen today. Primefac (talk) 00:34, 7 June 2024 (UTC)[]
Also noting that this has been (properly) reported at WP:VPT. Primefac (talk) 00:35, 7 June 2024 (UTC)[]
Yes, I went to VPT when I realized that I was unlikely to get a response here. And yet, I did! Liz Read! Talk! 03:53, 7 June 2024 (UTC)[]
I'm able to reproduce. Will load up the dev version and step debug it after dinner. P.S. It's broken in Vector and not Timeless, so maybe they implemented mw:Heading HTML changes on modern skins (vector, vector-2022, minerva) today. WP:THURSDAY. –Novem Linguae (talk) 04:25, 7 June 2024 (UTC)[]
Should be  Fixed. –Novem Linguae (talk) 06:51, 7 June 2024 (UTC)[]
Looks like, thanks! Primefac (talk) 10:21, 7 June 2024 (UTC)[]

Links not showing up in XFDcloser beta version[edit]

I am on Vector Legacy 2010 (always have been) and the problem persists. Jay 💬 13:00, 7 June 2024 (UTC)[]
Link to example page? Ill try loading your common.js and see if something is conflicting. –Novem Linguae (talk) 13:30, 7 June 2024 (UTC)[]
I was referring to RfD. Sorry for not mentioning. I have switched to Vector 2022 temporarily until Vector 2010 is fixed. Jay 💬 05:34, 8 June 2024 (UTC)[]
@Jay. I am unable to reproduce at Wikipedia:Redirects for discussion/Log/2024 June 1#2023-24 Major Clubs Limited Over Tournament. I see green close, quickClose, and relist links. Can you please confirm you don't see them? Can you also please post a screenshot? Do you have any WP:CONSOLEERRORs? –Novem Linguae (talk) 10:35, 11 June 2024 (UTC)[]

I don't see the green close, quickClose and relist links. When I change my skin from Vector 2010 to 2022, and refresh the RfD page, I see them. When I switch the preference back to 2010, the links are no longer seen. How do I post a screenshot? I was on Edge, but tried on Chrome as well. I see console errors like

2024_June_1:547  This page is using the deprecated ResourceLoader module "codex-search-styles".
[1.43] Use a CodexModule with codexComponents to set your specific components used: https://www.mediawiki.org/wiki/Codex#Using_a_limited_subset_of_components
(anonymous) @ 2024_June_1:547
startup.js:1307  This page is using the deprecated ResourceLoader module "jquery.ui".
Please use Codex instead.
execute @ startup.js:1307
startup.js:1307  This page is using the deprecated ResourceLoader module "mediawiki.ui".
[1.41] Please use Codex. See migration guidelines: https://www.mediawiki.org/wiki/Codex/Migrating_from_MediaWiki_UI
execute @ startup.js:1307
index.php?title=User:PrimeHunter/Source_links.js&action=raw&ctype=text/javascript:36
10Third-party cookie will be blocked. Learn more in the Issues tab.

— Preceding unsigned comment added by Jay (talkcontribs)

Thanks for that. Deprecation notices aren't anything to worry about. We're looking for things like "error" and "uncaught". Here's a graphic with more details about what to look for in the console.
To take a screenshot, you press your "Prt Scn" key, open a graphics program such as MS Paint, paste it in, save it, then upload it somewhere. Third party sites like imgur.com can be good for this if you're OK with not using FOSS. If you want to upload it to Commons for FOSS reasons, then you'd want to use c:Special:UploadWizard, although there are many more restrictions due to copyright. For example, you're supposed to crop out your operating system unless it's Linux, and you're only supposed to screenshot open source browsers such as Firefox, rather than proprietary software such as Chrome or Edge.
Two useful screenshots would be 1) the RFD page (so I can verify your skin) and 2) the console (so I can look at the error messages). –Novem Linguae (talk) 11:53, 11 June 2024 (UTC)[]
Actually, don't worry about the screenshots. I was able to reproduce this just now. Let me dig into it and I'll get back to ya. –Novem Linguae (talk) 11:58, 11 June 2024 (UTC)[]
[edit conflict] No, there are no errors. I know to take screenshots, uploading them was the question. Definitely do not want to upload to Commons where it will be permanent. Same for imgur I guess. Is there a site where images are kept for a day or so and purged? That will be perfect for screenshots. Jay 💬 12:03, 11 June 2024 (UTC)[]
Sent you the requested screenshots. Jay 💬 18:40, 11 June 2024 (UTC)[]
@Jay, Hey man im josh, and The Herald:. I deployed a fix related to the beta version of XFDcloser. Can you try again and let me know if things are fixed? –Novem Linguae (talk) 00:50, 13 June 2024 (UTC)[]
@Novem Linguae: It's back for me, at least with desktop mode from Chrome browser on my phone. Hey man im josh (talk) 00:57, 13 June 2024 (UTC)[]
Yes, awesome, you are the GOAT! Jay 💬 05:30, 13 June 2024 (UTC)[]
Amazing. Works perfect. I just love Monobook and didn't wanna switch. Thank you and happy editing :) — The Herald (Benison) (talk) 13:02, 13 June 2024 (UTC)[]

Would it be possible to have the script automatically post a message on the nominator's talk page once a discussion is closed? There would need to be a way for nominators to disable that if it annoys them though; not sure how it could be done. Cocobb8 (💬 talk • ✏️ contribs) 20:08, 10 June 2024 (UTC)[]

No comment on the feature, but more than a feature discussion, I think this is about responsibility. Of all participants, I believe the nominator ought to be the most responsible in tracking the discussion and seeing where it is going. For 7-day discussions, if I was a nom, I would check daily or once in two days. As part of making the nomination, the nom would also have the relevant pages in the watchlist. Jay 💬 07:46, 11 June 2024 (UTC)[]
Not sure this is necessary; just to use TFD as an example, there are a few editors who nominate dozens of pages every week for relatively mundane reasons, and they likely do not need or want to know the outcome of those discussions (never mind the fact that they're probably watching the template itself and will get a notification when the discussion is closed). They don't also need dozens of talk page notices each week telling them the outcome. Primefac (talk) 01:02, 15 June 2024 (UTC)[]