Page MenuHomePhabricator
Create Task
Maniphest T366172

[Generalised errors] Invalid path parameter
Closed, ResolvedPublic5 Estimated Story Points
Actions

Description

Acceptance criteria:

  • Current messages it will replace: Invalid ID forms (item, property, statement and site), invalid language code (labels, descriptions, aliases) across all endpoints
  • HTTP status code: 400
  • Error code: invalid-path-parameter
  • Error message: Invalid path parameter: '{parameter}'
  • Context: "parameter": "{matching element in path parameter in the OpenAPI spec}"

Details

SubjectRepoBranchLines +/-
REST: Use `invalid-path-parameter` for invalid language codes and site ids.mediawiki/extensions/Wikibasemaster+154 -177
REST: Replace `invalid-statement-id` with `invalid-path-parameter`mediawiki/extensions/Wikibasemaster+202 -177
REST: Replace `invalid-property-id` with `invalid-path-parameter`mediawiki/extensions/Wikibasemaster+329 -181
REST: Replace the `invalid-item-id` error with the generalized `invalid-path-parameter` one.mediawiki/extensions/Wikibasemaster+334 -201
REST: Use `invalid-path-parameter` for the remaining parameters.mediawiki/extensions/Wikibasemaster+632 -414
Customize query in gerrit

Related Objects

Event Timeline

Ifrahkhanyaree_WMDE created this task.May 29 2024, 12:45 PM
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptMay 29 2024, 12:45 PM
Ifrahkhanyaree_WMDE renamed this task from [Generalised errors] Incorrect path parameter to [Generalised errors] Invalid path parameter.Wed, Jun 5, 11:02 AM
Ifrahkhanyaree_WMDE updated the task description. (Show Details)
Ifrahkhanyaree_WMDE moved this task from Backlog to Polished on the Wikibase Product Platform Team WPP board.
Ifrahkhanyaree_WMDE updated the task description. (Show Details)Thu, Jun 6, 10:25 AM
Ifrahkhanyaree_WMDE set the point value for this task to 5.
Ifrahkhanyaree_WMDE moved this task from Polished to Ready for planning on the Wikibase Product Platform Team WPP board.Fri, Jun 7, 9:20 AM
Ifrahkhanyaree_WMDE moved this task from Ready for planning to Sprint 22 on the Wikibase Product Platform Team WPP board.Tue, Jun 11, 9:55 AM
Ifrahkhanyaree_WMDE edited projects, added Wikibase Product Platform Team WPP (Sprint 22); removed Wikibase Product Platform Team WPP.
Jakob_WMDE updated the task description. (Show Details)Wed, Jun 12, 1:07 PM
Jakob_WMDE subscribed.

Task breakdown notes:

  • adjust the request validating deserializers accordingly
  • adjust the examples in the spec
Muhammad_Yasser_Jazirahly_WMDE claimed this task.Sun, Jun 16, 1:41 PM
Muhammad_Yasser_Jazirahly_WMDE moved this task from To Do to Doing on the Wikibase Product Platform Team WPP (Sprint 22) board.
gerritbot added a comment.Tue, Jun 18, 7:59 PM

Change #1047169 had a related patch set uploaded (by Muhammad Jaziraly; author: Muhammad Jaziraly):

[mediawiki/extensions/Wikibase@master] REST: Replace the `invalid-item-id` error with the generalized `invalid-path-parameter` one.

https://gerrit.wikimedia.org/r/1047169

gerritbot added a project: Patch-For-Review.Tue, Jun 18, 7:59 PM
gerritbot added a comment.Tue, Jun 18, 8:10 PM

Change #1047170 had a related patch set uploaded (by Muhammad Jaziraly; author: Muhammad Jaziraly):

[mediawiki/extensions/Wikibase@master] REST: Use `invalid-path-parameter` for the remaining parameters.

https://gerrit.wikimedia.org/r/1047170

gerritbot added a comment.Wed, Jun 19, 2:34 PM

Change #1047531 had a related patch set uploaded (by Muhammad Jaziraly; author: Muhammad Jaziraly):

[mediawiki/extensions/Wikibase@master] REST: Replace the `invalid-property-id` error with the generalized `invalid-path-parameter` one.

https://gerrit.wikimedia.org/r/1047531

gerritbot added a comment.Wed, Jun 19, 3:08 PM

Change #1047541 had a related patch set uploaded (by Muhammad Jaziraly; author: Muhammad Jaziraly):

[mediawiki/extensions/Wikibase@master] REST: Replace the `invalid-statement-id` error with the generalized `invalid-path-parameter` one.

https://gerrit.wikimedia.org/r/1047541

gerritbot added a comment.Wed, Jun 19, 3:09 PM

Change #1047170 abandoned by Muhammad Jaziraly:

[mediawiki/extensions/Wikibase@master] REST: Use `invalid-path-parameter` for the remaining parameters.

Reason:

- will be divided into smaller patches

https://gerrit.wikimedia.org/r/1047170

gerritbot added a comment.Wed, Jun 19, 4:38 PM

Change #1047558 had a related patch set uploaded (by Muhammad Jaziraly; author: Muhammad Jaziraly):

[mediawiki/extensions/Wikibase@master] REST: Use `invalid-path-parameter` for invalid language codes and site ids.

https://gerrit.wikimedia.org/r/1047558

Muhammad_Yasser_Jazirahly_WMDE moved this task from Doing to Peer Review on the Wikibase Product Platform Team WPP (Sprint 22) board.Wed, Jun 19, 6:00 PM
gerritbot added a comment.Thu, Jun 20, 8:39 AM

Change #1047169 merged by jenkins-bot:

[mediawiki/extensions/Wikibase@master] REST: Replace the `invalid-item-id` error with the generalized `invalid-path-parameter` one.

https://gerrit.wikimedia.org/r/1047169

gerritbot added a comment.Fri, Jun 21, 9:52 AM

Change #1047531 merged by jenkins-bot:

[mediawiki/extensions/Wikibase@master] REST: Replace `invalid-property-id` with `invalid-path-parameter`

https://gerrit.wikimedia.org/r/1047531

gerritbot added a comment.Sat, Jun 22, 2:37 PM

Change #1047541 merged by jenkins-bot:

[mediawiki/extensions/Wikibase@master] REST: Replace `invalid-statement-id` with `invalid-path-parameter`

https://gerrit.wikimedia.org/r/1047541

gerritbot added a comment.Mon, Jun 24, 10:09 AM

Change #1047558 merged by jenkins-bot:

[mediawiki/extensions/Wikibase@master] REST: Use `invalid-path-parameter` for invalid language codes and site ids.

https://gerrit.wikimedia.org/r/1047558

Muhammad_Yasser_Jazirahly_WMDE moved this task from Peer Review to Done on the Wikibase Product Platform Team WPP (Sprint 22) board.Mon, Jun 24, 10:11 AM
Maintenance_bot removed a project: Patch-For-Review.Mon, Jun 24, 10:30 AM
ReleaseTaggerBot added a project: MW-1.43-notes (1.43.0-wmf.11; 2024-06-25).Mon, Jun 24, 11:00 AM
Ifrahkhanyaree_WMDE closed this task as Resolved.Tue, Jun 25, 10:08 AM
Ifrahkhanyaree_WMDE moved this task from Backlog to Done on the Wikibase REST API (WPP) board.Tue, Jun 25, 1:13 PM
Ollie.Shotton_WMDE mentioned this in T368398: [MAIN] REST API v1 CHECKLIST.Wed, Jun 26, 5:13 PM
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL · Credits