Lexeme lemma, sense or form editing should have a licence note
Closed, ResolvedPublic8 Estimated Story Points
Actions

Assigned To

Authored By

	Arian_Bozorg
	Aug 10 2023, 3:39 PM

Description

As an editor, I want to be informed about the license of contributions when I am editing a lemma, sense or form of a Lexeme.

Problem:
We currently don't show a "license of contributions" message when a lemma, sense or form of a Lexeme is edited like we do when a statement is added or edited.

We need to have the same message appear when a lemma, sense or form of a Lexeme is edited

Screenshot

Copy
By clicking "Publish", you agree to the terms of use, and you irrevocably agree to release your contribution under the Creative Commons CC0 License.

I accept these terms for my future edits. Do not show this message again.

BDD
GIVEN a Lexeme page
AND an editor wants to make a change
WHEN the edit button is clicked for a lemma, sense or form of a Lexeme
THEN the "license of contributions" message is displayed

Acceptance criteria:

"license of contributions" message is displayed when a lemma, sense or form of a Lexeme is edited

Details

	Subject	Repo	Branch	Lines +/-
	entityViewInit: Add hacks for Lexeme copyright notices	mediawiki/extensions/Wikibase	master	+33 -10

Customize query in gerrit

Related Objects

Mentioned In: T343998: [M] Item label, description and alias editing should have a license note
Mentioned Here: T343998: [M] Item label, description and alias editing should have a license note

Event Timeline

Arian_Bozorg created this task.Aug 10 2023, 3:39 PM

Restricted Application added a subscriber: Aklapper. · View Herald TranscriptAug 10 2023, 3:39 PM

Bugreporter added a project: Wikidata Lexicographical data.Aug 10 2023, 8:52 PM

Arian_Bozorg renamed this task from Lexeme lemma, sense or form editing should have a licence note to [SW] Lexeme lemma, sense or form editing should have a licence note.Aug 11 2023, 9:15 AM

Michael subscribed.Aug 14 2023, 11:31 AM

karapayneWMDE moved this task from Incoming to Product Backlog on the Wikidata Dev Team board.Aug 15 2023, 2:07 PM

Arian_Bozorg renamed this task from [SW] Lexeme lemma, sense or form editing should have a licence note to Lexeme lemma, sense or form editing should have a licence note.Aug 16 2023, 9:12 AM

Arian_Bozorg updated the task description. (Show Details)

karapayneWMDE moved this task from Product Backlog to Unified DOT Backlog on the Wikidata Dev Team board.Aug 16 2023, 9:38 AM

WMDE-leszek set the point value for this task to 8.Aug 22 2023, 9:38 AM

WMDE-leszek moved this task from Unified DOT Backlog to Sprint-∞ on the Wikidata Dev Team board.

WMDE-leszek edited projects, added Wikidata Dev Team (Sprint-∞); removed Wikidata Dev Team.

Task Breakdown Notes:

This uses wbtooltip, and therefore will rely on the tipsy jQuery UI plugin
A good place to start looking at thisa is attachCopyrightTooltip in repo/resources/wikibase.ui.entityViewInit.js

ItamarWMDE moved this task from Parents/Waiting to Todo/Backlog on the Wikidata Dev Team (Sprint-∞) board.Aug 23 2023, 10:16 AM

ItamarWMDE mentioned this in T343998: [M] Item label, description and alias editing should have a license note.Aug 23 2023, 10:18 AM

(I would wait with this until T343998: [M] Item label, description and alias editing should have a license note is done, since we can probably learn something from the implementation there.)

Michael moved this task from Wikidata.org Slice to Unified DOT Backlog on the Wikidata Dev Team board.Oct 9 2023, 8:57 AM

Michael edited projects, added Wikidata Dev Team; removed Wikidata Dev Team (Wikidata.org Slice).

hoo moved this task from Unified DOT Backlog to Wikidata.org Slice on the Wikidata Dev Team board.Oct 11 2023, 12:12 PM

hoo edited projects, added Wikidata Dev Team (Wikidata.org Slice); removed Wikidata Dev Team.

karapayneWMDE moved this task from Wikidata.org Slice to Unified DOT Backlog on the Wikidata Dev Team board.Oct 13 2023, 8:22 AM

karapayneWMDE edited projects, added Wikidata Dev Team; removed Wikidata Dev Team (Wikidata.org Slice).

I looked a bit into it, and the following patch

diff --git a/repo/resources/wikibase.ui.entityViewInit.js b/repo/resources/wikibase.ui.entityViewInit.js
index d88740deb1..bc83d49b82 100644
--- a/repo/resources/wikibase.ui.entityViewInit.js
+++ b/repo/resources/wikibase.ui.entityViewInit.js
@@ -355,7 +355,7 @@
 	 */
 	function attachCopyrightTooltip( $entityview, viewName ) {
 		$entityview.on(
-			'entitytermsviewafterstartediting sitelinkgroupviewafterstartediting statementviewafterstartediting',
+			'entitytermsviewafterstartediting sitelinkgroupviewafterstartediting statementviewafterstartediting lexemeviewafterstartediting',
 			function ( event ) {
 				var $target = $( event.target ),
 					gravity = 'sw';

is sufficient to have showCopyrightTooltip() get called when editing (lexemeheaderafterstartediting also works, but then we’d presumably also have to register lexemeformviewafterstartediting and senseviewafterstartediting – not sure which is better); but then showCopyrightTooltip() doesn’t do anything. It apparently has two mechanisms to show the copyright tooltip, either on an EditableTemplatedWidget or on an edittoolbar; in the case of the lexeme header, neither exists, so there’s nowhere to attach the message. We’ll have to look into which of these mechanisms fits us better, and how we can integrate it with the use of Vue.

hoo claimed this task.Nov 29 2023, 9:00 AM

hoo moved this task from Unified DOT Backlog to Wikidata.org Slice on the Wikidata Dev Team board.

hoo edited projects, added Wikidata Dev Team (Wikidata.org Slice); removed Wikidata Dev Team.

hoo moved this task from In Task Breakdown to In Development on the Wikidata Dev Team (Wikidata.org Slice) board.

Change 990719 had a related patch set uploaded (by Hoo man; author: Hoo man):

[mediawiki/extensions/Wikibase@master] entityViewInit: Add hacks for Lexeme copyright notices

https://gerrit.wikimedia.org/r/990719

gerritbot added a project: Patch-For-Review.Jan 15 2024, 4:13 PM

hoo moved this task from In Development to Ready for Peer Review on the Wikidata Dev Team (Wikidata.org Slice) board.Jan 15 2024, 4:14 PM

Attachment to the code review discussion (since I can’t upload images on Gerrit): here’s what the change looks like on my end for the lemmas :/

Lucas_Werkmeister_WMDE moved this task from Ready for Peer Review to In Peer Review on the Wikidata Dev Team (Wikidata.org Slice) board.Jan 18 2024, 1:12 PM

Change 990719 merged by jenkins-bot:

[mediawiki/extensions/Wikibase@master] entityViewInit: Add hacks for Lexeme copyright notices

https://gerrit.wikimedia.org/r/990719

Lucas_Werkmeister_WMDE moved this task from In Peer Review to Product Verification on the Wikidata Dev Team (Wikidata.org Slice) board.Jan 24 2024, 4:48 PM

Maintenance_bot removed a project: Patch-For-Review.Jan 24 2024, 5:31 PM

ReleaseTaggerBot added a project: MW-1.42-notes (1.42.0-wmf.16; 2024-01-30).Jan 24 2024, 7:01 PM

Looks good to me :) thanks so much!

	F41695550: image.png
	Jan 17 2024, 1:45 PM

Lexeme lemma, sense or form editing should have a licence noteClosed, ResolvedPublic8 Estimated Story PointsActions

Description

Details

Related Objects

Event Timeline

Lexeme lemma, sense or form editing should have a licence note
Closed, ResolvedPublic8 Estimated Story Points
Actions