Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[css-values][all] Define all URL usages in terms of Fetch #562

Closed
tabatkins opened this issue Oct 3, 2016 · 4 comments
Closed

[css-values][all] Define all URL usages in terms of Fetch #562

tabatkins opened this issue Oct 3, 2016 · 4 comments
Assignees
@tabatkins
Labels
css-values-4 Current Work css-values-5 topic: urls Tracking issues that'll need edits when CSS URLs are defined on top of Fetch.

Comments

@tabatkins
Copy link
Member

The platform has settled on using the Fetch model to define fetching. CSS currently hand-waves a bunch of this, and as a result there are some browser-compat issues with corner cases, like what referrer to use in various situations.

WebAppSec defines some of this behavior for us (and here), which we should move into a CSS spec.

(This is mostly a tracking bug to remind me to do this, and track links to useful resources. If anyone else clueful would like to help, feel free.)
@tabatkins tabatkins added the css-values-4 Current Work label Oct 3, 2016
@tabatkins tabatkins self-assigned this Oct 3, 2016
@xfq xfq mentioned this issue Apr 16, 2019
Closed
@svgeesus svgeesus mentioned this issue Oct 5, 2020
Closed
@fantasai fantasai added topic: urls Tracking issues that'll need edits when CSS URLs are defined on top of Fetch. css-values-5 labels Sep 23, 2021
@noamr noamr mentioned this issue Oct 3, 2021
Closed
16 tasks
@noamr
Copy link
Collaborator

noamr commented Oct 3, 2021

I don't believe this is going to be difficult to accomplish.
Where should a common algorithm for fetching style resources sit? [css-values]?

@noamr noamr mentioned this issue Oct 3, 2021
Closed
@tabatkins
Copy link
Member Author

My own experience so far suggests that it definitely is difficult to accomplish. ^_^ But I'd absolutely welcome help in defining this, if you have better insight into the problem.

Currently our attempts at fetching things are spread between CSSOM (for top-level stylesheet; currently broken and not invoking the Fetch algos correctly) and Cascade (for @import; currently being written by me in an attempt to use the Fetch algos correctly but definitely currently broken too).

I suspect that url() usage in properties should generally be quite easy; there's a lot less observable behavior we have to worry about, but there's still some piping of document state thru stylesheets that probably needs to be done in CSSOM. Values & Units is indeed the appropriate place to define the general handling of url() tho; PRs absolutely welcome.

@noamr
Copy link
Collaborator

noamr commented Oct 4, 2021

My own experience so far suggests that it definitely is difficult to accomplish. ^_^ But I'd absolutely welcome help in defining this, if you have better insight into the problem.

Fair enough :) this was a motivated offer of help rather than an attempt to belittle the challenge

Currently our attempts at fetching things are spread between CSSOM (for top-level stylesheet; currently broken and not invoking the Fetch algos correctly) and Cascade (for @import; currently being written by me in an attempt to use the Fetch algos correctly but definitely currently broken too).

I suspect that url() usage in properties should generally be quite easy; there's a lot less observable behavior we have to worry about, but there's still some piping of document state thru stylesheets that probably needs to be done in CSSOM. Values & Units is indeed the appropriate place to define the general handling of url() tho; PRs absolutely welcome.

They’re coming, be warned. 😉
Will probably have a multi-spec PR with some open issues in the next couple of days

@noamr noamr mentioned this issue Oct 5, 2021
Merged
@noamr
Copy link
Collaborator

noamr commented Nov 8, 2021

@tabatkins I believe this can be closed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@tabatkins tabatkins

Labels
css-values-4 Current Work css-values-5 topic: urls Tracking issues that'll need edits when CSS URLs are defined on top of Fetch.
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@noamr @tabatkins @fantasai